Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for parsing & timestamp extraction for PushIDs #43

Open
t3hmrman opened this issue Dec 7, 2023 · 0 comments · May be fixed by #47
Open

Feature: Add support for parsing & timestamp extraction for PushIDs #43

t3hmrman opened this issue Dec 7, 2023 · 0 comments · May be fixed by #47
Labels
enhancement New feature or request feature/pushid Related to the PushID generation help wanted Extra attention is needed size/md Size: Medium tech-debt

Comments

@t3hmrman
Copy link
Member

t3hmrman commented Dec 7, 2023

Context

Upstream implementation of pushid is not quite enough -- it's lacking in two major areas:

  • Parsing strings into internal representation PushIDs
  • Extracting timestamps from generated PushIDs

Proposal

Upstream changes should be made, then vendored, and eventually accepted upstream in order to add the functionality to pushid.

Alternatives

N/A

Additional Links

There is already one PR for adding functionality upstream:

silverbeak/rust-push-id#1

There is also a branch underway:

https://github.com/VADOSWARE/pg_idkit/tree/feat/pushid/add-timestamp-extraction-and-parsing
@t3hmrman t3hmrman added enhancement New feature or request help wanted Extra attention is needed size/md Size: Medium tech-debt feature/pushid Related to the PushID generation labels Dec 7, 2023
@t3hmrman t3hmrman linked a pull request Dec 8, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature/pushid Related to the PushID generation help wanted Extra attention is needed size/md Size: Medium tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pushid): add timestamp extraction & parsing VADOSWARE/pg_idkit
1 participant
@t3hmrman