Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesa table can have double tooltips #1245

Open
bobular opened this issue Oct 24, 2024 · 4 comments
Open

Mesa table can have double tooltips #1245

bobular opened this issue Oct 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bobular
Copy link
Member

bobular commented Oct 24, 2024

I noticed this in ortho (on the orthogroup-tree-table branch) - the "All groups" results , if the EC number column overflows, the first tooltip is black text on yellow (from <Tooltip> I assume) and then the second is white text on dark grey (presumably the browser 'title' attr rendering).

Sorry no movie!

@bobular bobular added the bug Something isn't working label Oct 24, 2024
@bobular
Copy link
Member Author

bobular commented Oct 24, 2024

Looks like packages/libs/wdk-client/src/Views/ResultTableSummaryView/ResultTable.tsx is using the renderCell prop which is using packages/libs/wdk-client/src/Views/ResultTableSummaryView/AttributeCell.tsx for cells, and this has its own overflow/tooltip implementation.

Possible solution is to not do the new setTitle stuff in packages/libs/coreui/src/components/Mesa/Ui/DataCell.jsx when 'renderCell' in column

@dmfalke
Copy link
Member

dmfalke commented Oct 24, 2024

I'm not looking at the code, but I remember there being a Mesa prop to prevent those tooltips.

@dmfalke
Copy link
Member

dmfalke commented Oct 24, 2024

@dmfalke
Copy link
Member

dmfalke commented Oct 24, 2024

I think we should consider removing the Tooltip from AttributeCell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants