Orthogroup tree table protein filter #1252
Conversation
|
There's something strange about the When you have a large group (OG7_0000011) and no text search at all, it takes around a second for the checkbox clicks to register. When you have a search active (e.g. "123") it's more snappy. I cannot see why! |
|
Note: there seems to be no urgent need to address the debouncing quirks in |
| ? ` (${volatileProteinFilterIds.length})` | ||
| : '' | ||
| }`} | ||
| key={volatileProteinFilterIds.join(':')} |
There was a problem hiding this comment.
This isn't needed
| key={volatileProteinFilterIds.join(':')} |
There was a problem hiding this comment.
I think it is necessary - or if we remove it we need another way to close the popover after an action button is clicked
There was a problem hiding this comment.
I see. This could use a comment.
I'm not a big fan of using keys like this, but it does solve this problem.
There are two ways we can avoid using key, here:
- Have
PopoverButtontake anopenprop that can be used to control the internal state. - Have
PopoverButtontake a ref that exposes aclose()and anopen()method.
Both have their pros and cons. The first option means introducing more state for the consumer, and more state management for the PopoverButton component, but it uses props, which is more common. The latter doesn't not introduce new state and works better with event handlers, but custom refs are not nearly as common to work with.
There was a problem hiding this comment.
I didn't expose an open() method just yet. We can grow into that!
| buttonDisplayContent={`Proteins${ | ||
| volatileProteinFilterIds.length > 0 | ||
| ? ` (${volatileProteinFilterIds.length})` | ||
| : '' | ||
| }`} |
There was a problem hiding this comment.
Should we change the label when rows are selected, to indicate that the underlying filter is operable?
There was a problem hiding this comment.
I've added an asterisk just as a placeholder (though the asterisk is also used inside the popover, so maybe it's good)
There's an edge case where say you are filtered on 6 proteins and you select-all 6 proteins and then click "refine filter" the filter widget doesn't close automatically (because ourSolved ✔️keydoesn't change)