Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ortho 7 - minor UX upgrades #1254

Open
7 of 8 tasks
bobular opened this issue Oct 30, 2024 · 4 comments · Fixed by #1259
Open
7 of 8 tasks

Ortho 7 - minor UX upgrades #1254

bobular opened this issue Oct 30, 2024 · 4 comments · Fixed by #1259
Assignees

Comments

@bobular
Copy link
Member

bobular commented Oct 30, 2024

  • warning about filtered trees not being same as a tree from filtered protein seqs
  • tree/table mismatch warning verbiage and link to contact page, make sure all cases are handled (tree is superset of table not currently caught?)
  • Filter should capitalize Core/Peripheral
  • See if core/peripheral counts are easy
  • Text search instructions are wrong... fixed the search behaviour to match the other tables
  • table paging and protein filtering are a bit dodgy. Probably just need to reset to page 1 when applying the protein filter.
  • Test SelectList button labelling in EDA/MBio (lineplot numerator/denominator, mbio diff abundance condition selectors and elsewhere?)
  • Handle excessive "Previous Groups" in header with a "more..." link.
@bobular bobular self-assigned this Oct 30, 2024
@bobular
Copy link
Member Author

bobular commented Nov 1, 2024

image

@bobular
Copy link
Member Author

bobular commented Nov 1, 2024

Decided against adding counts for Core and Peripheral in the popover.

The easier way to do it is to add the numbers in parentheses to the display labels in items. However, then these will get shown in the button after the popover is closed, so I'm not sure I like that.

The harder way is to make a new SelectListWithCounts component (or add new functionality to SelectList). Not going to do that unless there's a clear use-case.

@bobular
Copy link
Member Author

bobular commented Nov 1, 2024

Well, good thing I added that final testing task! Will look into it tomorrow.

image

@bobular
Copy link
Member Author

bobular commented Nov 2, 2024

This is sorted now
image

@bobular bobular linked a pull request Nov 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant