Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ortho 7 - table text search is flaky #1260

Open
bobular opened this issue Nov 1, 2024 · 3 comments
Open

Ortho 7 - table text search is flaky #1260

bobular opened this issue Nov 1, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bobular
Copy link
Member

bobular commented Nov 1, 2024

Depending on the size of the group and the speed of your typing, the behaviour can be very flaky (missed characters, or characters appear to be typed and then get undone soon after). I'm having the most problems with OG7_0000779, but it's likely dependent on the speed of your computer also.

The RealTimeSearchBox in RecordFilter is likely the cause. It has some issues. We should consider removing the debouncing and using useDeferredValue. This will require refactoring the component to a functional component...

@bobular bobular added the bug Something isn't working label Nov 1, 2024
@dmfalke dmfalke self-assigned this Nov 4, 2024
@bobular
Copy link
Member Author

bobular commented Nov 13, 2024

This is fixed, isn't it? @dmfalke

@dmfalke
Copy link
Member

dmfalke commented Nov 13, 2024

This is fixed, isn't it? @dmfalke

I think so. I will test when the databases are back online.

@dmfalke
Copy link
Member

dmfalke commented Nov 13, 2024

I'm getting consistent results, but it's still laggy. The table can end up updating multiple times, if you aren't typing quickly. Each update can be pretty slow (several seconds), especially for larger groups. I need to spend more time profiling this to see where the time is being spent.

Something we can do in the immediate term is increase the delay for the search box (just in this instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants