Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to add new matching methods #85

Open
roquelopez opened this issue Oct 7, 2024 · 0 comments · May be fixed by #87
Open

Make it easier to add new matching methods #85

roquelopez opened this issue Oct 7, 2024 · 0 comments · May be fixed by #87

Comments

@roquelopez
Copy link
Collaborator

Currently all the algorithms for schema and value matching are grouped into a single module (algorithms.py). Ideally, each algorithm should be in a different module under a common package (e.g. . If external contributor want to add new methods, they just would need to create a new module.

Also, move SchemaMatchers and ValueMatchers (Enums) to __init__.py of this common package.

@roquelopez roquelopez changed the title Make essier to add new matching methods Make it easier to add new matching methods Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant