Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running experiment is blocking reprounzip-qt #334

Open
remram44 opened this issue Dec 3, 2018 · 0 comments
Open

Running experiment is blocking reprounzip-qt #334

remram44 opened this issue Dec 3, 2018 · 0 comments
Labels
C-unpack-gui Component: The Qt unpacking GUI (reprounzip-qt) good first issue Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase hacktoberfest Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase T-enhancement Type: En enhancement to existing code, or a new feature

Comments

@remram44
Copy link
Member

remram44 commented Dec 3, 2018

The process should be waited on using signals rather than blocking the main thread.

This is not a big deal in practice (no interaction with the app is possible while the experiment is running) but can cause the window to go blank or show a "not responding" warning.

@remram44 remram44 added T-enhancement Type: En enhancement to existing code, or a new feature C-unpack-gui Component: The Qt unpacking GUI (reprounzip-qt) labels Dec 3, 2018
@remram44 remram44 added good first issue Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase hacktoberfest Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase labels Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-unpack-gui Component: The Qt unpacking GUI (reprounzip-qt) good first issue Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase hacktoberfest Newcomers welcome! This should be easy and self-contained enough for someone new to the codebase T-enhancement Type: En enhancement to existing code, or a new feature
Projects
None yet
Development

No branches or pull requests

1 participant