Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: включить declarationMap в TS для пакета @vkontakte/vkui #5593

Closed
inomdzhon opened this issue Aug 9, 2023 · 1 comment · Fixed by #5748
Closed

[Feature]: включить declarationMap в TS для пакета @vkontakte/vkui #5593

inomdzhon opened this issue Aug 9, 2023 · 1 comment · Fixed by #5748
Assignees
@mendrew
Labels
technical task type:feature
Milestone
v5.9.0

Comments

@inomdzhon
Copy link
Contributor

inomdzhon commented Aug 9, 2023 •
edited
Loading

Описание

Для опции declarationMap необходимо добавлять в конечный билд директорию packages/vkui/src/, исключив оттуда следующие файлы и папки:

  • src/**/*.png
  • src/**/*.*.ts
  • src/**/*.*.tsx
  • src/vkui.js
  • src/testing/
  • src/storybook/

Нюансы

Yarn v1 не умеет в исключения в package.json#files (см. #3261 и yarnpkg/yarn#7888), поэтому придётся делать большой .npmignore (см. #5392 (comment))

UPD

Стоит дождаться задачи [Tech]: обновить Yarn до v3 #5594.
@inomdzhon inomdzhon added this to VKUI Aug 9, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Aug 9, 2023
@inomdzhon inomdzhon mentioned this issue Aug 9, 2023
Closed
@inomdzhon inomdzhon moved this from 🗃 Backlog to ⛔️ Blocked in VKUI Aug 9, 2023
@inomdzhon inomdzhon added this to the 5.9.0 milestone Aug 22, 2023
@mendrew mendrew self-assigned this Aug 31, 2023
@mendrew mendrew moved this from ⛔️ Blocked to 🔧 In progress in VKUI Sep 8, 2023
@mendrew mendrew mentioned this issue Sep 11, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🔧 In progress to ✅ Done in VKUI Sep 11, 2023
@vkcom-publisher
Copy link
Contributor

✅ v5.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mendrew mendrew

Labels
technical task type:feature
Projects
VKUI
Archived in project
Milestone
v5.9.0
Development

Successfully merging a pull request may close this issue.

tech: turn on declaration map for vkui package VKCOM/VKUI
3 participants
@mendrew @inomdzhon @vkcom-publisher