Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SimpleCell. badgeAfterTitle уходит вправо, если указан пропс multiline #8102

Closed
meowto16 opened this issue Dec 18, 2024 · 1 comment · Fixed by #8144
Closed

[Bug]: SimpleCell. badgeAfterTitle уходит вправо, если указан пропс multiline #8102

meowto16 opened this issue Dec 18, 2024 · 1 comment · Fixed by #8144
Assignees
@EldarMuhamethanov
Labels
cmp:simple-cell type:bug
Milestone
v7.1.1

Comments

@meowto16
Copy link
Contributor

Описание

У компонента SimpleCell, пропс badgeAfterTitle при указанном multiline={true} должен работать также, как и при multiline={false}. А именно - не уезжать направо.

Версия

7.0.0

В каких браузерах воспроизводится проблема?

Firefox, Chrome, Safari, Microsoft Edge

Шаги воспроизведения

  1. Берем SimpleCell
  2. Добавляем любую иконку в badgeAfterTitle
    2.1) Видим, что иконка находится рядом с children'ом
  3. Добавляем пропс multiline={true}
  4. Наблюдаем, как badgeAfterTitle уезжает направо из-за display:flex, justify-content: space-between правил

Ожидаемое поведение

badgeAfterTitle ведет себя также, как если пропс multiline не указан

Скриншоты

image
image

Пример с воспроизведением

https://codesandbox.io/p/sandbox/intelligent-hugle-77vqxq
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Dec 18, 2024
@andrey-medvedev-vk andrey-medvedev-vk moved this from 🗃 Backlog to 🔜 To do in VKUI Dec 18, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Jan 13, 2025
@EldarMuhamethanov EldarMuhamethanov moved this from 🔜 To do to 🔧 In progress in VKUI Jan 13, 2025
@EldarMuhamethanov EldarMuhamethanov mentioned this issue Jan 13, 2025
Merged
2 tasks
@EldarMuhamethanov EldarMuhamethanov moved this from 🔧 In progress to 👀 In Review in VKUI Jan 13, 2025
@inomdzhon inomdzhon added this to the v7.1.1 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Jan 15, 2025
@vkcom-publisher
Copy link
Contributor

✅ v7.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:simple-cell type:bug
Projects
VKUI
Archived in project
Milestone
v7.1.1
Development

Successfully merging a pull request may close this issue.

fix(Header, SimpleCell): fix icons position with multiline VKCOM/VKUI
5 participants
@inomdzhon @meowto16 @EldarMuhamethanov @vkcom-publisher @andrey-medvedev-vk