Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

officially but very softly deprecate geom_xxx_rast #22

Closed
jan-glx opened this issue Feb 1, 2021 · 2 comments
Closed

officially but very softly deprecate geom_xxx_rast #22

jan-glx opened this issue Feb 1, 2021 · 2 comments

Comments

@jan-glx
Copy link
Contributor

jan-glx commented Feb 1, 2021

In #21 (comment)_ @evanbiederstedt wrote:

Throwing a warning at this stage after several months feels a bit confusing/pedantic. I worry it will cause more confusion than necessary.

I agree that hard or even soft deprecation that throws a warning at top-level might cause more harm than good, but you could document it as deprecated (as opposed to the current labeling as equal alternative), I believe that would make the use of ggraster easier to learn and teach in the long run.

@evanbiederstedt
Copy link
Collaborator

Hi @jan-glx

you could document it as deprecated (as opposed to the current labeling as equal alternative), I believe that would make the use of ggraster easier to learn and teach in the long run.

Yes, we tried to detail this in the README and the vignettes: https://htmlpreview.github.io/?https://raw.githubusercontent.com/VPetukhov/ggrastr/master/doc/Raster_geoms.html

There might be a better solution for users to clarify that e.g. geom_xxx_rast is a historical remnant.

In terms of learning and teaching, that's definitely something for the vignettes. Please let us know if there's more we could do here.

@evanbiederstedt
Copy link
Collaborator

It's a nice suggestion, but I think the current setup is the best of all worlds.

I do see where you're coming from of course. Besides mentioning this in the README and vignettes however, I don't see a better way to "deprecate" in this case. .Deprecated() is simply too strong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants