Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SolutionIndicators #1169

Closed
jcoupey opened this issue Oct 16, 2024 · 0 comments · Fixed by #1170
Closed

Refactor SolutionIndicators #1169

jcoupey opened this issue Oct 16, 2024 · 0 comments · Fixed by #1170
Labels
refactor
Milestone
v1.15.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Oct 16, 2024

It occurred to me that while currently SolutionIndicators is a template class, it does not have to be. Instead we could have only a template ctor (the one used when constructing indicators from a std::vector<Route> that is a template). This would simplify a lot of downstream usage of SolutionIndicators instances where we currently have other template types and functions.
@jcoupey jcoupey added this to the v1.15.0 milestone Oct 16, 2024
@jcoupey jcoupey mentioned this issue Oct 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

Remove some template complexity. VROOM-Project/vroom
1 participant
@jcoupey