Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero accumulated distance for last break #475

Closed
jcoupey opened this issue Mar 25, 2021 · 0 comments · Fixed by #476
Closed

Zero accumulated distance for last break #475

jcoupey opened this issue Mar 25, 2021 · 0 comments · Fixed by #476
Labels
Milestone

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Mar 25, 2021

I spotted a situation where having a final break in an open-ended optimization (i.e. without a vehicle end) can result in a zero duration reported for the break step:

$vroom -g -i final_break_without_end.json | jq '.routes[].steps[] | [.type, .duration, .distance]' 
[
  "start",
  0,
  0
]
[
  "job",
  4401,
  79134
]
[
  "job",
  5107,
  96317
]
[
  "break",
  5107,
  0
]
[
  "end",
  5107,
  96317
]

This is related to the fact that we try to compute added distance pro-rata temporis and accumulated travel times do not increase.

Not directly related to #463 but touches the exact same part of the code.

@jcoupey jcoupey added the bug label Mar 25, 2021
@jcoupey jcoupey added this to the v1.10.0 milestone Mar 25, 2021
@jcoupey jcoupey mentioned this issue Mar 25, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant