Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libvroom example to CI builds #514

Closed
jcoupey opened this issue May 17, 2021 · 0 comments · Fixed by #519
Closed

Add libvroom example to CI builds #514

jcoupey opened this issue May 17, 2021 · 0 comments · Fixed by #519

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented May 17, 2021

Every now and then, we do some refactoring of the C++ API or internal data structures that break the build for libvroom_examples/libvroom.cpp. This usually go unnoticed until someone reports it like in #510 so it would be nice to add a simple build check in the CI setup.

Note: this is not about treating failed builds as an error as we don't provide any guarantee of stability of the C++ API, but rather a way to spot changes so that the example stays in sync with core updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant