Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit for Timeout is not obvious #728

Closed
kkarbowiak opened this issue Jun 21, 2022 · 2 comments
Closed

Unit for Timeout is not obvious #728

kkarbowiak opened this issue Jun 21, 2022 · 2 comments
Labels
C++ API enhancement
Milestone
v1.13.0

Comments

@kkarbowiak
Copy link
Contributor

Currently, Timeout is defined as std::optional<unsigned> which is confusing, as it does not convey what the timeout unit is. Only by digging deeper into the code one finds a comment that internally milliseconds are used.

We can make it more self-explanatory and type-safe by changing the type to std::optional<std::chrono::milliseconds>.
@kkarbowiak kkarbowiak mentioned this issue Jun 21, 2022
Merged
2 tasks
@jcoupey
Copy link
Collaborator

jcoupey commented Jun 23, 2022

Definitely makes sense, thanks for the suggestion and the associated PR.

@jcoupey jcoupey added this to the v1.13.0 milestone Jun 23, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Jun 30, 2022

Landed with #729.

@jcoupey jcoupey closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ API enhancement
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
2 participants
@jcoupey @kkarbowiak