Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify routing wrapper add_route_info #957

Closed
jcoupey opened this issue Jul 26, 2023 · 0 comments · Fixed by #1001
Closed

Simplify routing wrapper add_route_info #957

jcoupey opened this issue Jul 26, 2023 · 0 comments · Fixed by #1001

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Jul 26, 2023

Currently every routing wrapper implements the virtual Wrapper::add_route_info function to populate the route geometry and the routes[].steps[].distance values in output. This means the same logic is duplicated in various files to populate the distances, with small subtle differences depending on the underlying routing engine.

Once we have #956, we should be able to simply populate Step::distance values during the solution formatting process just as for Step::duration. Then we could turn the various *::add_route_info to much simpler *::add_geometry functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant