Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor position at wrong place #1043

Closed
hpsoar opened this issue Nov 7, 2016 · 6 comments
Closed

cursor position at wrong place #1043

hpsoar opened this issue Nov 7, 2016 · 6 comments
Labels

Comments

@hpsoar
Copy link

hpsoar commented Nov 7, 2016

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.

After Ctrl+V, I move the cursor and did some selection, see the picture below.

screen shot 2016-11-07 at 5 40 05 pm

then, I press s to do substitution.
In this case, the cursor should be placed at the beginning of line 3, while the fact is as the picture below.

screen shot 2016-11-07 at 5 40 16 pm

  • VSCode Version:
  • VsCodeVim Version: v0.4.1
  • OS: Mac
    10.11.6 (15G31)
@hpsoar
Copy link
Author

hpsoar commented Nov 7, 2016

After that, if I input some text, the text is inserted at the right place.
The only problem is that the cursor is not placed at the right position.

@xconverge
Copy link
Member

This is true for A and I as well, should be able to take a look. did @rebornix ask you to assign him? Otherwise I could look at it

@hpsoar
Copy link
Author

hpsoar commented Nov 8, 2016

@rebornix did not ask me to assign him. I don't know who assigned it.

@hpsoar
Copy link
Author

hpsoar commented Nov 8, 2016

modeHandler, vimState.currentMode === VisualBlockInsertMode, thus execute the following code
Line 1400: selections = [ new vscode.Selection(stop, stop) ];

don't know how to fix this, should just change stop to start or a new Mode is needed?

@rebornix
Copy link
Member

rebornix commented Nov 8, 2016

@xconverge I assign it to myself. It's GitHub's bug :) But I did that for testing, so @xconverge go ahead

@xconverge
Copy link
Member

ah ok yea I saw "@rebornix rebornix was assigned by hpsoar 13 hours ago"

I am almost done fixing this

@rebornix rebornix removed their assignment Nov 9, 2016
@jpoon jpoon closed this as completed in 060c2dd Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants