Surround replacement of quotes adds unwanted whitespace

[hmps]

Since commit 75e2cae extra whitespace is added when using Surround to add / modify quotes.

---

What did you do?

"Hello |World"
Press: cs"'

What did you expect to happen?

"Hello World" => 'Hello World'

What happened instead?

"Hello World" => ' Hello World '

Technical details:

In commit 75e2cae, quotes were added to PairMatcher with nextMatchIsForward set to true. This causes the logic in GetStartAndEndReplacements (actions.ts) to add the whitespace.

• VSCode Version: 1.9.1
• VsCodeVim Version: 0.5.3
• OS: macOS 10.12.3

[xconverge]

perfect investigation, I am not sure the best way to fix this but it is easily fixable. Will see what @johnfn thinks about the fixes in my pr

[hmps]

Hehe, that was a simple fix. Thank you so much for fixing that so promptly @xconverge!

⭐

[xconverge]

@hmps yea there were quite a few other improvements done to surround so it should be pretty solid now, I will take another pass in the future if there are more small things found