Vim handles keystrokes in wrong sequence if Code is not responding immediately

[rebornix]

• Try to update Line 4466 of the action.ts of this project and you are adding a ) after }
• Press Esc and then . quickly.
• The content ends up with }). and the state is normal mode.

Code takes a few seconds to handle match bracket logic after you press ) so that's why the Esc doesn't immediately change the cursor style to Block real quick. However Code is sending the events with correct sequence but we didn't handle them in a good order

Code type: a
Vim Handler: a
Code type: )
Vim Handler: )
Code key: <Esc>
Code type: .
Vim handler: .
Vim handler: <Esc>

[johnfn]

Ah, interesting, they get out of sequence.

One good way to reproduce this is to write some code that introduces a random delay before handling events.

[Chillee]

Could this piece of code be the cause?

https://github.com/VSCodeVim/Vim/blob/master/src/actions/commands/actions.ts#L102

[Chillee]

Oh shit I think I found the reason why @rebornix @johnfn @xconverge
https://github.com/VSCodeVim/Vim/blob/master/extension.ts#L357

    registerCommand(context, keybinding.command, () => handleKeyEvent(`${ bracketedKey }`));

We have a task queue that is meant to handle the above scenario. However, when we're handling special keys, we just ignore the task queue!

[rebornix]

@Chillee very likely a good catch!

[knewter]

This is the only thing I dislike about editing in vscode, but it's a huge deal for me. I very frequently run I<esc>ww or something similar to get to the second word in a line. I know it's not ideal vim golf but it's muscle memory. 80% of the time, this results in inserting the text ww at the front of the line and staying in insert mode :-\