Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the jump list is wrong #1688

Closed
haolly opened this issue May 11, 2017 · 13 comments
Closed

the jump list is wrong #1688

haolly opened this issue May 11, 2017 · 13 comments

Comments

@haolly
Copy link

haolly commented May 11, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


** Is this a BUG REPORT **:

Environment:

  • VSCode Version: 1.12.1
  • VsCodeVim Version: 0.7.1
  • OS: win 10

What happened:
put cursor on a function call, the gd to the definition of the function, kk move cursor up two line,
press ctrl-o to go back to the function call

What did you expect to happen:
the cursor goes back to the previous function call
How to reproduce it:
as described above

I think the main problem is that the jump-motions is not correctly handled,

jump-motions
A "jump" is one of the following commands: "'"', "`", "G", "/", "?", "n",
"N", "%", "(", ")", "[[", "]]", "{", "}", ":s", ":tag", "L", "M", "H" and
the commands that start editing a new file. If you make the cursor "jump"
with one of these commands, the position of the cursor before the jump is
remembered. You can return to that position with the "''"' and "``" command,
unless the line containing that position was changed or deleted.

@Chillee
Copy link
Member

Chillee commented May 12, 2017

I think that's because we don't really handle jump lists extensively. We merely bind ctrl+o to the vim command workbench.action.navigateBack.

@haolly
Copy link
Author

haolly commented May 13, 2017

@Chillee so, is there any plane to improve it ?

@Chillee
Copy link
Member

Chillee commented May 13, 2017

I've been meaning to take a look at it, but it's not a top priority for me. At least for my use case, the current ctrl+o works well enough most of the time.

@haolly
Copy link
Author

haolly commented Jul 8, 2017

@Chillee does it help this issue when Neovim is integrated ?

@Chillee
Copy link
Member

Chillee commented Jul 8, 2017

@haolly Yes neovim integration will solve this issue completely.

@haolly
Copy link
Author

haolly commented Jul 8, 2017

@Chillee I just tested on my mac, with neovim integrated, still does not work properly

@Chillee
Copy link
Member

Chillee commented Jul 8, 2017

@haolly it's not merged yet.

#1897 is the pr you want to be following.

@nsaje
Copy link

nsaje commented May 7, 2018

This is keeping me from using VSCode as well. Without the vim plugin VSCode handles this correctly, it's only when the plugin is enabled that it stops working.

I did some research and I think this is due to this line in VSCode - I think all VSCodeVim actions are interpreted as API actions by VSCode and are put on the history stack. Anyone knows where the actions are dispatched in VSCodeVim and if it's possible to change them to be non-api?

@crachmanin
Copy link

I noticed that this is only an issue for 'j' and 'k', other movements like 'l', 'h', 'w', or 'b' do not affect the jump history. #2461 is the same issue.

@FancyFurret
Copy link

Is there any update to this issue? Was about to switch to VS Code, but without jump lists working properly it is unusable...

@mikeys
Copy link

mikeys commented Jul 26, 2018

Guys, any plan for handling this? Really annoying

@shawnaxsom
Copy link
Contributor

This is fixed in a branch where I am working on implementing our own proper jump list. See my comments here: #1933

@Chillee
Copy link
Member

Chillee commented Sep 13, 2018

I think @shawnaxsom has handled this issue in the PR linked above. Thanks!

@Chillee Chillee closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants