Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo in a file in a split window undoes too many actions #2109

Closed
geordanr opened this issue Nov 1, 2017 · 3 comments
Closed

Undo in a file in a split window undoes too many actions #2109

geordanr opened this issue Nov 1, 2017 · 3 comments

Comments

@geordanr
Copy link

geordanr commented Nov 1, 2017

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug Report

Environment:

  • VSCode Version: 1.17.2
  • VsCodeVim Version: 0.10.2
  • OS: Ubuntu 17.10, Windows 10

What happened:

Switching to a split window and performing an undo undoes all the previous actions in the other split.

What did you expect to happen:

Only the most recent action should have be undone. Instead, that action, plus all the actions that occurred in the other split, were undone. In the example below, only the insertion of garply should have been undone; instead, that plus all the other insertions in the other split (bar and baz) were undone.

How to reproduce it:

  1. Open a new, untitled file
  2. Ctrl-\ to split the window
  3. Insert text and return to normal mode: ifoo^[
  4. Switch to other split: ^W^W
  5. Perform multiple actions (e.g. multiple text inserts): obar^[obaz^[
  6. Switch back to first split: ^W^W
  7. Insert text: ogarply^[
  8. Undo: u
@kdheepak
Copy link

I've had the same issue and I believe this is related #565. Any thoughts from core team members?

@kdheepak
Copy link

I meant to say #928.

@jpoon
Copy link
Member

jpoon commented Jan 16, 2018

Yep. Closing this in favor of #928 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants