-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use vscode's config folder for .cmdline_history #2799
Comments
@jpoon Do you know where we are "supposed" to put this stuff? I am able to get the path in .vscode/extension/vscodevim with exposed APIs and can put it there.... |
My vote is for |
Please don't use ~/.vscode either as it doesn't respect XDG. The vscode config is split right now and the "correct" one is in the XDG dir. Also see: microsoft/vscode#3884 |
We will not be hardcoding it, we will be using an API provided by vscode to get the working directory for the extension that is installed. So for now, that would be .vscode/extension/vscodevim but as soon as the issue you linked is executed upon, we would be placing the file in the new location automatically |
Please use %AppData% in Windows. Configuration files should not be stored in %UserProfile% in Windows. |
How can we disable history from being saved and this directory and file from being created for the time being? Setting |
No one has suggested a folder that other people havent disagreed with so I am a bit stuck here... I can implement it for the next release if we can agree on a location |
I guess to be clean this would be blocked by microsoft/vscode#2741 ? |
@xconverge Speaking about specifically the The canonical location for Mac and Linux systems I think would be As an aside: I'd also personally prefer the directory to be completely lowercase with optional word hyphenation, rather than pascal case since sorting will be a bit more sane. (so, |
I think this is the common way for Windows. https://stackoverflow.com/questions/8789172/temporary-directory-persist-across-program-runs/8789288#8789288 |
Ok I think XDG_CACHE_HOME or LOCALAPPDATA for windows will keep everyone happy for now. If anything fails, it falls back to the current location (home directory). On my mac I didn't have XDG_CACHE_HOME set for example so it used the home directory still. How does that sound? |
That works for me since I have that explicitly set, but it's technically non-compliant to the specification, since it should automatically fall back to ~/.cache/<app_name>/ if XDG_CACHE_HOME is not set. Just throwing that out there for completeness. If this is just a temporary solution until a better one can be made, that's totally fine. |
Ok I decided to use a library for now, just tested it on 3 platforms with these results:
This issue will be closed and I will push a release. Please let me know if something still doesn't seem right once you start using the new release! |
Is this a BUG REPORT or FEATURE REQUEST? (choose one): Enhancement
vscode-vim has recently started creating a ~/.VSCodeVim folder in $HOME, which pollutes the home dir :(
There already is a config folder for vscode in
$XDG_CONFIG_HOME/Code
. Can you move that folder there instead please?The text was updated successfully, but these errors were encountered: