Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot search for words which include slashes #4200

Closed
moetayuko opened this issue Oct 21, 2019 · 7 comments
Closed

Cannot search for words which include slashes #4200

moetayuko opened this issue Oct 21, 2019 · 7 comments
Assignees

Comments

@moetayuko
Copy link

Describe the bug
Suppose the target word is /usr/share, to search for it in native vim I use /\/usr\/share<Enter>, but in vscodevim neither the preceding one nor //usr/share<Enter> does work.

To Reproduce
As above

Expected behavior
The word in text matches.

Environment (please complete the following information):

  • Extension (VsCodeVim) version:1.11.2
  • VSCode version:1.39.2
  • OS:Linux x64 5.3.7-arch1-1-ARCH
@meowjesty
Copy link

I'm using vscodevim 1.0.4 (on Windows) and /\/usr\/share<Enter> works as expected.

@moetayuko
Copy link
Author

ff

@J-Fields
Copy link
Member

J-Fields commented Oct 23, 2019

Yeah this does seem like a bug. My hunch is that I screwed this up when implementing search offsets. I can take a look later this week or this weekend, so I'll self-assign, but if someone else wants to tackle this, feel free.

@meowjesty just wondering - why do you use such an old version?

@J-Fields J-Fields self-assigned this Oct 23, 2019
@meowjesty
Copy link

@J-Fields because of #3455

@J-Fields
Copy link
Member

@meowjesty That should be fixed by #4074. Might be worth giving the latest release a shot!

@moetayuko
Copy link
Author

@J-Fields Thanks for the fix!

@J-Fields
Copy link
Member

Do note that a forward search for / and a backward search for ? each require a backslash escape now (I don't think they did before this was broken). This is in line with Vim, at least on the default magic level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants