Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exceptions when run ca( with no {} test case #474

Closed
rebornix opened this issue Jul 19, 2016 · 4 comments
Closed

Throw exceptions when run ca( with no {} test case #474

rebornix opened this issue Jul 19, 2016 · 4 comments
Labels

Comments

@rebornix
Copy link
Member

Technical details:

  • VSCode Version: 1.4.0-Insiders
  • VsCodeVim Version: Master Branch
  • OS: Windows 10 Enterprise

Even though finally all test cases pass, I've seen following exceptions..

will fail when ca( with no {}
error.stack
Error: what in god's name
    at ModeHandler.<anonymous> (c:\Users\cici\code\Vim\src\mode\modeHandler.ts:788:13)
    at undefined.next (native)
    at __awaiter (c:\Users\cici\code\Vim\src\mode\modeHandler.ts:1:14)
    at __awaiter (c:\Users\cici\code\Vim\src\mode\modeHandler.ts:1:14)
    at ModeHandler.executeOperator (c:\Users\cici\code\Vim\src\mode\modeHandler.ts:782:51)
will fail when ca( with no () (1439ms)

@rebornix
Copy link
Member Author

@sectioneight any idea on this one?

@ascandella
Copy link
Contributor

I've seen this as well. I think this was introduced in the "cancellation" code in #466 but haven't tracked it down yet

@johnfn
Copy link
Member

johnfn commented Jul 19, 2016

I know why this is. It's actually not terrible, since the user won't notice at all. Still should be fixed at some point.

@johnfn johnfn added the size/M label Jul 19, 2016
@rebornix
Copy link
Member Author

This issue is tracked in #700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants