Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmap J :m '>+1<CR>gv=gv and vmap K :m '<-2<CR>gv=gv do not work as expected #9262

Open
ykhan21 opened this issue Sep 15, 2024 · 1 comment
Open

Comments

@ykhan21
Copy link

ykhan21 commented Sep 15, 2024

Describe the bug
vmap J :m '>+1<CR>gv=gv and vmap K :m '<-2<CR>gv=gv do not work as expected.
These mappings work in vim but not in VSCodeVim. Normally, they allow you to highlight a few lines and then move them with J or K.

To Reproduce
Steps to reproduce the behavior:

  1. Add the two remaps above to your .vimrc.
  2. In VSCodeVim, use them by highlighting a line with V. Then try moving the line down with the J mapping.
  3. Observe these mappings do not work.

Expected behavior
Normally, these maps allow you to highlight a few lines and then move them with J or K.

Log

2024-09-15 14:50:01.540 [debug] Handling key: V
2024-09-15 14:50:01.541 [debug] Status bar: -- VISUAL LINE --
2024-09-15 14:50:03.263 [debug] Handling key: J
2024-09-15 14:50:03.263 [debug] Remapping J to :,m, ,',>,+,1,
,g,v,=,g,v
2024-09-15 14:50:03.263 [debug] Handling key: :
2024-09-15 14:50:03.287 [debug] Status bar: :'<,'>|
2024-09-15 14:50:03.287 [debug] Handling key: m
2024-09-15 14:50:03.290 [debug] Status bar: :'<,'>m|
2024-09-15 14:50:03.290 [debug] Handling key:
2024-09-15 14:50:03.294 [debug] Status bar: :'<,'>m |
2024-09-15 14:50:03.294 [debug] Handling key: '
2024-09-15 14:50:03.297 [debug] Status bar: :'<,'>m '|
2024-09-15 14:50:03.298 [debug] Handling key: >
2024-09-15 14:50:03.300 [debug] Status bar: :'<,'>m '>|
2024-09-15 14:50:03.301 [debug] Handling key: +
2024-09-15 14:50:03.304 [debug] Status bar: :'<,'>m '>+|
2024-09-15 14:50:03.304 [debug] Handling key: 1
2024-09-15 14:50:03.307 [debug] Status bar: :'<,'>m '>+1|
2024-09-15 14:50:03.307 [debug] Handling key:
2024-09-15 14:50:03.308 [info] Executing :'<,'>m '>+1
2024-09-15 14:50:03.308 [debug] Adding Transformation {"type":"deleteRange","range":[{"line":3,"character":0},{"line":4,"character":0}],"manuallySetCursorPositions":true}
2024-09-15 14:50:03.308 [debug] Adding Transformation {"type":"insertText","position":{"line":4,"character":6},"text":"\n\t"context"","diff":{"type":0,"line":4,"character":1}}
2024-09-15 14:50:03.319 [debug] 2 change(s) to c:\Users\KhanY_z23jg7i\repos\price-fetcher\metrics.go because undefined
2024-09-15 14:50:03.321 [debug] Set nextStepStartPosition to [3, 0]
2024-09-15 14:50:03.321 [debug] Status bar: -- NORMAL --
2024-09-15 14:50:03.321 [debug] Handling key: g
2024-09-15 14:50:03.323 [debug] Handling key: v
2024-09-15 14:50:03.324 [debug] Status bar: -- VISUAL LINE --
2024-09-15 14:50:03.324 [debug] Handling key: =
2024-09-15 14:50:03.366 [debug] Status bar: -- NORMAL --
2024-09-15 14:50:03.366 [debug] Handling key: g
2024-09-15 14:50:03.367 [debug] Handling key: v
2024-09-15 14:50:03.368 [debug] Status bar: -- VISUAL LINE --
2024-09-15 14:50:03.368 [debug] Finished history step with 2 change(s)
2024-09-15 14:50:03.802 [debug] Handling key: J
2024-09-15 14:50:03.803 [debug] Remapping J to :,m, ,',>,+,1,
,g,v,=,g,v
2024-09-15 14:50:03.803 [debug] Handling key: :
2024-09-15 14:50:03.826 [debug] Status bar: :'<,'>|
2024-09-15 14:50:03.826 [debug] Handling key: m
2024-09-15 14:50:03.830 [debug] Status bar: :'<,'>m|
2024-09-15 14:50:03.830 [debug] Handling key:
2024-09-15 14:50:03.834 [debug] Status bar: :'<,'>m |
2024-09-15 14:50:03.834 [debug] Handling key: '
2024-09-15 14:50:03.837 [debug] Status bar: :'<,'>m '|
2024-09-15 14:50:03.838 [debug] Handling key: >
2024-09-15 14:50:03.841 [debug] Status bar: :'<,'>m '>|
2024-09-15 14:50:03.841 [debug] Handling key: +
2024-09-15 14:50:03.844 [debug] Status bar: :'<,'>m '>+|
2024-09-15 14:50:03.845 [debug] Handling key: 1
2024-09-15 14:50:03.848 [debug] Status bar: :'<,'>m '>+1|
2024-09-15 14:50:03.849 [debug] Handling key:
2024-09-15 14:50:03.849 [info] Executing :'<,'>m '>+1
2024-09-15 14:50:03.849 [debug] Adding Transformation {"type":"deleteRange","range":[{"line":3,"character":0},{"line":4,"character":0}],"manuallySetCursorPositions":true}
2024-09-15 14:50:03.849 [debug] Adding Transformation {"type":"insertText","position":{"line":4,"character":10},"text":"\n\t"fmt"","diff":{"type":0,"line":4,"character":1}}
2024-09-15 14:50:03.854 [debug] 2 change(s) to c:\Users\KhanY_z23jg7i\repos\price-fetcher\metrics.go because undefined
2024-09-15 14:50:03.854 [debug] Set nextStepStartPosition to [3, 0]
2024-09-15 14:50:03.855 [debug] Status bar: -- NORMAL --
2024-09-15 14:50:03.855 [debug] Handling key: g
2024-09-15 14:50:03.857 [debug] Handling key: v
2024-09-15 14:50:03.857 [debug] Status bar: -- VISUAL LINE --
2024-09-15 14:50:03.857 [debug] Handling key: =
2024-09-15 14:50:03.874 [debug] Status bar: -- NORMAL --
2024-09-15 14:50:03.874 [debug] Handling key: g
2024-09-15 14:50:03.876 [debug] Handling key: v
2024-09-15 14:50:03.876 [debug] Status bar: -- VISUAL LINE --
2024-09-15 14:50:03.876 [debug] Finished history step with 2 change(s)
2024-09-15 14:50:09.734 [debug] Handling key:
2024-09-15 14:50:09.735 [debug] Status bar: -- NORMAL --
2024-09-15 14:50:11.993 [info] Active editor: output:vscodevim.vim.Vim

Environment (please complete the following information):

  • Extension (VsCodeVim) version: v1.28.1
  • VSCode version: Version: 1.93.1 (user setup)
  • OS: Windows 11
@darianmorat
Copy link

// settings.json
   "vim.visualModeKeyBindings": [
      { "before": ["K"], "commands": ["editor.action.moveLinesUpAction"] },
      { "before": ["J"], "commands": ["editor.action.moveLinesDownAction"] }
   ]

In VISUAL or VISUAL LINE mode, J and K now move lines up and down, while automatically adjusting indentation.
Most nvim tricks can be accomplish using the settings.json or keybindings.json since they offer a lot of options to play with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants