Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with comments broke with recent versions #9270

Open
Ten0 opened this issue Sep 20, 2024 · 0 comments
Open

Integration with comments broke with recent versions #9270

Ten0 opened this issue Sep 20, 2024 · 0 comments

Comments

@Ten0
Copy link

Ten0 commented Sep 20, 2024

Describe the bug

A few releases ago, it became possible to use VSCode Vim when editing comments from the Github Pull Requests extension.
This was absolutely amazing, and game changer when writing comments. (Vim ❤️)

image

However since a very recent release (of VSCode probably), pressing escape while in insertion mode, instead of returning to normal mode, cancels writing the comment, closes the dialog and discards the text.
In one hour of reviewing PRs, it's the 4th super detailed comment I have to entirely rewrite because it's hardwired in my brain that I can press escape to exit insertion mode, and that actually closes the comment dialog. (So by the way there's no way to exit insertion mode.)
I'm going crazy. 😭
Please help! 🏝️🏳️

Thanks in advance!

To Reproduce
Steps to reproduce the behavior:

  1. Install VSCode VIM & Github Pull Requests extension
  2. Open a PR
  3. Start writing a comment
  4. Enter insertion mode and write some text
  5. Press escape.

Expected behavior
Exits insertion mode, not closing the dialog.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.28.1
  • VSCode version: 1.93.0
  • Github Pull Requests version: 0.96.0
  • OS: Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant