Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use end key to go to end of the line in insert mode or select in visual mode #934

Open
ta3pks opened this issue Oct 18, 2016 · 10 comments · May be fixed by #5842
Open

Cannot use end key to go to end of the line in insert mode or select in visual mode #934

ta3pks opened this issue Oct 18, 2016 · 10 comments · May be fixed by #5842

Comments

@ta3pks
Copy link

ta3pks commented Oct 18, 2016

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.


What did you do?

v<end> d

What did you expect to happen?

supposed to select until the end of line and delete

What happened instead?

it behaves very strangely goes to the end of the line, but as soon as some action takes place it acts like the cursor has not moved

Technical details:

  • VSCode Version:1.6.1
  • VsCodeVim Version: 0.3.7
  • OS: Ubuntu 16.4
@xconverge
Copy link
Member

This should be fixed in master already by @rebornix

@ta3pks
Copy link
Author

ta3pks commented Oct 18, 2016

@xconverge well when are we expecting to see the new release :)

@xconverge
Copy link
Member

Ah only one of the cases was fixed so far, end while in insert works but not to select in visual, sorry about that (This issue wasn't targeted specifically, was just partially fixed as a byproduct of a different issue)

I will try to take a look tonight!

@kevincoleman
Copy link
Contributor

kevincoleman commented Oct 27, 2016

I’m experiencing something very similar to this, and I think (by the description) it’s probably related. In both insert mode and normal mode hitting the end key performs as expected, but then the next input still acts as though the cursor didn’t move to the end of the line.

Not sure if this is after-the-fact since it sounds like it’s already fixed in master, but I figured since I’m seeing it I’d further describe the problem in case it persists. 😄

@davidgiven
Copy link

The same thing happens with PgUp/PgDn --- try this:

v PgDn CursorRight

...the cursor will snap back to where it was before you pressed PgDn.

I think there's a similar disconnect between vscodevim's idea of where the cursor is and where vscode's idea of where the cursor is that caused #924.

Are there any alternatives to special-casing all the motion keys? Because otherwise we're going to be playing whackamole with motion keys for the next year...

@johnfn
Copy link
Member

johnfn commented Oct 28, 2016

@davidgiven Unfortunately, there's no alternative. We have to register every key manually. Easy explanation: for macros to work, they have to record every key, and the only way we can record the key is if we've registered it.

@xconverge
Copy link
Member

Also not the next year, there are a handful left and if you continue to report them we will continue to fix them :)

@xconverge
Copy link
Member

I think that this is fixed in #1006 and I did Home in another PR

v PgDn is still not working though, but it is similar to #907

@davidgiven
Copy link

PgUp and PgDn still don't work --- in block mode they're even more exciting than in line mode, because not only do they not change the selection, they move the cursor (I can see it in the scrollbar) and the scroll position doesn't change, leading to the cursor being way off the screen! Pressing left or right causes the cursor snap back to the selection, though...

@ReedyBear
Copy link
Contributor

[end] and [home] appear to work in v 1.16.0. [PgUp] & [PgDn] still don't seem to work. I didn't test in newly released 1.17.0.

Possibly related:

Perhaps this issue ([end] key) should be closed?

@berknam berknam linked a pull request Dec 9, 2020 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants