Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/vhdl/user_guide: add VHDL 1993 variant #737

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Sep 6, 2021

I was chatting with @rodrigomelo9, as it seems that the usage of the user guide with simulators which don't support 2008 completely is unclear.

In this PR, subdir vhdl1993 is added to examples/vhdl/user_guide, and the sources are adapted to use VHDL 1993. Precisely, the optional vhdl_standard argument is used when calling from_argv, and the context in VHDL sources is replaced with use statements.

By the way, an skipIf decorator is added to the 2008 version in the acceptance tests, so that it is skipped with simulators that don't support contexts.

/cc @rodrigomelo9

@rodrigomelo9
Copy link
Contributor

Hi @umarcor. Sorry, I was unclear. context is supported by Xcelium and the user guide which is written in VHDL 2008 is fine. I think that "my" confusion, was related to the fact that the acceptance test is prepared to check VHDL 2008. Using 1993, more tests fail.

@LarsAsplund LarsAsplund merged commit 14b5ad1 into VUnit:master Sep 7, 2021
@umarcor umarcor deleted the ug-93 branch September 7, 2021 19:33
@eine eine added this to the v4.6.0 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants