Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pdfjs-dist as peerDependency #535

Closed
jkroepke opened this issue Nov 10, 2019 · 13 comments
Closed

Add pdfjs-dist as peerDependency #535

jkroepke opened this issue Nov 10, 2019 · 13 comments
Labels

Comments

@jkroepke
Copy link

Bug Report or Feature Request (mark with an x)
- [ ] Regression (a behavior that used to work and stopped working in a new release)
- [ ] Bug report -> please search issues before submitting
- [x] Feature request
- [ ] Documentation issue or request

Since ng2-pdf-viewer has some great improvements but stick on the lastest version of pdfjs-dist I would ask if its possible to add pdfjs-dist as peerDependency instead as real dependency.

The lastest version of pdfjs-dist has some issues with CSP
(mozilla/pdf.js#11036) while the 2.1.266 version not.

Goal: I would like to use the lastest of ng2-pdf-viewer with the 2.1.266 version pdfjs-dist

Currently I stick on 5.3.2 of ng2-pdf-viewer since this the lastest version which depends on 2.1.266

See also: #419

@jkroepke jkroepke changed the title Add pdfjs-dist as peeDependency Add pdfjs-dist as peerDependency Nov 10, 2019
@stale
Copy link

stale bot commented Jul 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2020
@jkroepke
Copy link
Author

Still a need.

@stale stale bot removed the stale label Jul 31, 2020
@stale
Copy link

stale bot commented Sep 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2020
@jkroepke
Copy link
Author

Make some activity.

@stale stale bot removed the stale label Sep 29, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 28, 2020
@jkroepke
Copy link
Author

unstale

@stale stale bot removed the stale label Nov 28, 2020
@stale
Copy link

stale bot commented Jan 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 27, 2021
@jkroepke
Copy link
Author

unstale

@stale stale bot removed the stale label Jan 27, 2021
@stale
Copy link

stale bot commented Mar 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 28, 2021
@VadimDez VadimDez removed the stale label Mar 28, 2021
@stale
Copy link

stale bot commented May 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 28, 2021
@jkroepke
Copy link
Author

okay you won.

@adamdport
Copy link

@jkroepke did you ever figure this out? I tried running your specific versions (ng2-pdf-viewer@5.3.2 and pdfjs-dist@2.1.66) and it won't even run Module '"pdfjs-dist"' has no exported member 'PDFPromise'. With the latest ng2-pdf-viewer I get CSP issues and it seems like they expect it to be working now? Should I make another issue or has this been working for you?

@jkroepke
Copy link
Author

I left that project. I don't know if it's resolved or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants