-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pdfjs-dist as peerDependency #535
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still a need. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Make some activity. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
unstale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
unstale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
okay you won. |
@jkroepke did you ever figure this out? I tried running your specific versions (ng2-pdf-viewer@5.3.2 and pdfjs-dist@2.1.66) and it won't even run |
I left that project. I don't know if it's resolved or not. |
Bug Report or Feature Request (mark with an
x
)Since ng2-pdf-viewer has some great improvements but stick on the lastest version of pdfjs-dist I would ask if its possible to add
pdfjs-dist
as peerDependency instead as real dependency.The lastest version of pdfjs-dist has some issues with CSP
(mozilla/pdf.js#11036) while the 2.1.266 version not.
Goal: I would like to use the lastest of ng2-pdf-viewer with the 2.1.266 version pdfjs-dist
Currently I stick on 5.3.2 of ng2-pdf-viewer since this the lastest version which depends on 2.1.266
See also: #419
The text was updated successfully, but these errors were encountered: