Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented and confusing behavior of setPage method #6

Open
reinvanoyen opened this issue Sep 21, 2016 · 1 comment
Open

Undocumented and confusing behavior of setPage method #6

reinvanoyen opened this issue Sep 21, 2016 · 1 comment
Assignees

Comments

@reinvanoyen
Copy link

reinvanoyen commented Sep 21, 2016

First of all, let me thank you for creating this wonderful component. It works great and gives a native feel on mobile devices.

I just wanted to let you know I found it confusing that, when trying to set the swiper to the first element, you have to set it using setPage(1) instead of setPage(0). When using setPage(0), it's not clear it doesn't work like that, because it actually scrolls to the first item. It's upon swiping you notice there's something wrong when you have to swipe twice to get to the next slide. It would've saved me a lot of time if this was either:

  • Implemented like most people expect it to be (setPage(0)) where the first item is represented by 0, we're programmers, right?
  • If this confusing behavior was documented.

Just my two cents.

Thanks again for the wonderful component!

@ValorLin
Copy link
Owner

Sorry, I didn't noticed that.
Thank you for let me know what a big mistake I've made.

@ValorLin ValorLin self-assigned this Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants