Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton 5.13-3 RC testing #4435

Closed
aeikum opened this issue Dec 4, 2020 · 17 comments
Closed

Proton 5.13-3 RC testing #4435

aeikum opened this issue Dec 4, 2020 · 17 comments

Comments

@aeikum
Copy link
Collaborator

aeikum commented Dec 4, 2020

Hello. We've put together a new 5.13 build for you to test over the weekend.

In the Steam client, the Proton 5.13 app should have a "next" beta branch which you can choose to start testing the 5.13-3 release candidates (note that the name of the build in the Steam Settings dialog will not be updated). I will post changes here when we push new builds. The source for the latest RC build is available on the proton_5.13-next branch in these repositories. This branch may receive forced updates.

In this issue, we are interested only in problems that are new to the 5.13-3 RC builds. If you find new problems in the "next" branch, please confirm that the problem does not occur in on the "default" branch before reporting it here.

Here is the tentative changelog. As always, this changelog has not yet been verified by our QA staff, and can change before the final release as we add or remove features during RC testing.

-Restore controller hotplugging.
-Yakuza: Like A Dragon, Soulcalibur 6, Lords of the Fallen, and Hammerting are now playable.
-Fix sound in Warframe and Ghostrunner.
-Fix flickering graphics in Serious Sam 4.
-Fix networking failures in Call of Duty: World War II.
-Fix Age of Empires II HD crash in multiplayer lobbies.
-Fix Paradox games launchers.
-Update FAudio to 20.12.
-Update DXVK to v1.7.3.

@misyltoad
Copy link
Contributor

In Okami HD (587620), in the previous version of Proton 5.13 (not next) when a Steam Controller was attached the game would crash (after to lsteamclient changes)

In Proton 5.13-next, the game no longer crashes but the Steam Controller does absolutely nothing, it doesn't even act as if it's in lizard mode.

Any inputs on the controller while the game is active have no effect.

@kisak-valve
Copy link
Member

Hello @Joshua-Ashton, can you check if the non-beta and beta Steam client have the same controller behavior for you? We had ValveSoftware/steam-for-linux#7507 come in today and it would be good to confirm that what you're seeing is not related to that issue report.

@misyltoad
Copy link
Contributor

@kisak-valve Same behaviour on normal Steam here.

@mindinsomnia
Copy link

mindinsomnia commented Dec 5, 2020

@kisak-valve Is there a current active issue for reporting issues with Proton 5.13+ defaulting to the wrong GPU on laptops? This issue is still present in 5.13-3 RC and has existed since 5.13-1, I'm not sure where to report this.

Right now for all current 5.13 versions of Proton that use DX10 and up I have to use the command line option DXVK_FILTER_DEVICE_NAME to specify my dedicated GPU so that it doesn't use the Intel onboard GPU. Otherwise I just get a frozen image of my desktop before the game started, until I alt tab out and force close the game.

@kisak-valve
Copy link
Member

Hello @mindinsomnia, I recall a comment being made that the order the Vulkan loader picks up the .json of different drivers is undefined and there might be different results inside of the Steam Linux Runtime container compared to the host system. Looking around for a bit, I didn't find that comment in a reasonable amount of time. Ideally, it would be nice if you could reproduce the issue with a native Linux game running Vulkan inside of Steam Linux Runtime and report the issue on the steam-runtime issue tracker.

@rejexy
Copy link

rejexy commented Dec 5, 2020

How can I disable runtime in this proton version? Can you add following env?

@misyltoad
Copy link
Contributor

misyltoad commented Dec 5, 2020

@kisak-valve Hm, I actually went back and tested Proton 4.2 and the same issue is occurring there now.

Appears that my Steam Controller is just broken in all Proton titles -- it works in Big Picture mode etc.

Tried both beta/non-beta Steam.

@misyltoad
Copy link
Contributor

@kisak-valve

I tested a native Steam game I worked on a while ago that uses Steam Input and yeah, nothing.

Just appears that Steam Input is broken globally on Beta/non-Beta.

@kisak-valve
Copy link
Member

Hello @rejedai, running the mainline Proton 5.13 build outside of Steam Linux Runtime - Soldier is not supported. If you're seeing an issue with the runtime container, it should be investigated instead of avoided. Issues with the runtime are being tracked in the steam-runtime issue tracker.

@Leopard1907
Copy link

@mindinsomnia #4289 (comment)
It is mentioned here and afterwards but no addition is made to the issues list.

Current workaround is disabling runtime container which can be done like this:

flightlessmango/MangoHud#369 (comment)

GL games doesn't offer any device selection so usage of those vars on multiple gpu systems ( igpu+dgpu) is needed to determine which gpu will be used and also Vulkan games like Doom 2016 doesn't offer a device selection mechanism too so it is needed for Vulkan side as well.

@alesliehughes
Copy link

alesliehughes commented Dec 5, 2020

-Update DXVK to v1.7.3.

I've just reported the issue below. Its a divide by zero error in the above dxvk release which might need to be addressed.
doitsujin/dxvk#1843

Updated
As of dxvk commit 03f11ba, GhostRunner works once again.

@XirXes
Copy link

XirXes commented Dec 6, 2020

Excited to see controller hotplugging back in. Tested with San Andreas with Ginput mod installed, hotplugging worked for me with an Xbox One controller though the wireless controller adapter and xow. If I had steam input enabled for xbox controllers the steam client would hang on reconnect, though the game keeps running fine, never notifying its using my controller profile, or sending input to the game. But once I close San Andreas the client recovers and the notification pops. Let me know how I can pull an effective log on this.
Ginput is a mod to add xinput to the 1.0 version of San Andreas.

Confirmed the same behavior with Monster Hunter World.

@alasky17
Copy link
Collaborator

alasky17 commented Dec 7, 2020

@XirXes did you try waiting over 60 seconds after reconnecting the controller? There is a bug being investigated right now that can cause a game to freeze for a full 30s and take a total of up to 1 full minute for the controller to reconnect when Steam overlay is on.

@alasky17
Copy link
Collaborator

alasky17 commented Dec 7, 2020

-Update DXVK to v1.7.3.

I've just reported the issue below. Its a divide by zero error in the above dxvk release which might need to be addressed.
doitsujin/dxvk#1843

Updated
As of dxvk commit 03f11ba, GhostRunner works once again.

@alesliehughes Thank you for pointing out that cherry-pick! Final build should have it :)

@XirXes
Copy link

XirXes commented Dec 7, 2020

@alasky17 I did confirm that with some patience the controller does begin responding again after about a minute. Interestingly however, I found that GTA IV running under proton doesn't have that lag, and the controller works immediately after reconnection. The games never freeze during the wait for me, just the steam client. Once the steam client comes back the controller does work again under San Andreas.

To expand on things that may not be well confirmed, I now have rumble working in every game I play that has it, and every session as well. Previously I wasn't having any consistency with it, I would have rumble in the first launch of a proton game in my session, but I had to reboot to get it back. I was having the issue primarily with GTA V, but I've had issues with rumble in non native games for the majority of the year, and that seems to be resolved.

@alasky17
Copy link
Collaborator

alasky17 commented Dec 7, 2020

@XirXes Thank you for the update. Glad to know it is not a new bug and that rumble is working consistently 👍

WRT the Steam mapping hotplugging - I also found one game that doesn't have the super duper long delay for hotplugging; it is super weird. Folks are still digging into the source of the problem, so if you are interested in following along - the issue is tracked here: https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/issues/38#note_15958

@aeikum
Copy link
Collaborator Author

aeikum commented Dec 7, 2020

Hi all. Thank you for testing. 5.13-3 has been released, so I am closing this issue.

@aeikum aeikum closed this as completed Dec 7, 2020
@aeikum aeikum unpinned this issue Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants