Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quotes within comments are not handled properly #24

Closed
fivegrant opened this issue Oct 13, 2022 · 3 comments
Closed

Single quotes within comments are not handled properly #24

fivegrant opened this issue Oct 13, 2022 · 3 comments

Comments

@fivegrant
Copy link

' will not be handled properly in the following:

Table something.thing {
  id int [note: "this statement CAN'T be compiled correctly"]
}
@Vanderhoof
Copy link
Owner

@fivegrant could you check if you have the most recent version? It should have been fixed in 1.0.2 (latest is 1.0.3)

>>> from pydbml import PyDBML
>>> d = PyDBML("""
... Table something.thing {
...   id int [note: "this statement CAN'T be compiled correctly"]
... }
... """)
>>> d.tables[0]
<Table 'something' 'thing'>
>>> d.tables[0][0]
<Column 'id', 'int'>
>>> d.tables[0][0].note
Note("this statement CAN'T be compiled correctly")

@Vanderhoof
Copy link
Owner

Ah, ok, there's still a problem with exporting quotes. Will be fixed in the next version!

>>> print(d.dbml)
Table "something"."thing" {
    "id" int [note: 'this statement CAN'T be compiled correctly']
}

@Vanderhoof
Copy link
Owner

Vanderhoof commented Oct 23, 2022

Fixed in 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants