Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polka instead of Express #342

Closed
cktang88 opened this issue Jul 18, 2019 · 3 comments
Closed

Use polka instead of Express #342

cktang88 opened this issue Jul 18, 2019 · 3 comments
Assignees
Labels
blocked good first issue Good for newcomers Priority: Low Low priority Type: Chore Maintainance, refactoring, code cleanup Type: Enhancement New feature or request

Comments

@cktang88
Copy link
Contributor

Since we only use Express for like one tiny file, might as well use Polka https://github.com/lukeed/polka
compatible with express middleware, 90 LOC, no external deps

@leonm1 leonm1 added Priority: Low Low priority Type: Chore Maintainance, refactoring, code cleanup simple Type: Enhancement New feature or request good first issue Good for newcomers labels Jul 19, 2019
@konoikon konoikon self-assigned this Jul 30, 2019
@konoikon
Copy link
Member

I'm not sure if we want to proceed with this option. Since Polka hasn't released its first version yet, there is no type declaration file available through npm.

However, if we want to proceed, this guy created a custom declaration file that is supported and edited by polka's author. How would you like to proceed with this?

@konoikon konoikon removed their assignment Jul 30, 2019
@cktang88
Copy link
Contributor Author

Ah I see. Thanks for investigating this. I think we should probably wait until the official types come out to implement this, shouldn't be too long.

For people following this, the link tracking types support here: lukeed/polka#17

@bencooper222
Copy link
Member

Project looks dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked good first issue Good for newcomers Priority: Low Low priority Type: Chore Maintainance, refactoring, code cleanup Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants