Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Synthetic Root Feature Should be Abstract #14

Open
pmbittner opened this issue Oct 17, 2022 · 0 comments
Open

Generated Synthetic Root Feature Should be Abstract #14

pmbittner opened this issue Oct 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pmbittner
Copy link
Member

The generation of feature models from a list of feature names is implemented in FeatureModelUtils.FromOptionalFeatures and creates a synthetic root node to gather all given features as optional children. The generated root is not abstract which makes it configurable, biasing any analyses (such as #SAT). The root should be made mandatory and should probably also get a name that has a smaller changes of naming conflicts.

final Feature root = new Feature(fm, "Root");
fm.addFeature(root);
fm.getStructure().setRoot(root.getStructure());

@pmbittner pmbittner added the bug Something isn't working label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant