Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet whitelist does not affect blocks without a BlockItem #4648

Closed
gamma-delta opened this issue Feb 8, 2024 · 1 comment
Closed

Magnet whitelist does not affect blocks without a BlockItem #4648

gamma-delta opened this issue Feb 8, 2024 · 1 comment

Comments

@gamma-delta
Copy link
Contributor

Hello, I am working on a modpack where you have to move a single unbreakable block around to do a lot of tasks, and I want to use Quark for its magnet. So I've added the block to the magnet whitelist, but it doesn't react.

I think this is because of the way the list of magnetic blocks is created. Zeta's api for recursively finding crafted items only works on items. Because I've purposely made the block not have a BlockItem (to make sure the player can't accidentally pick it up), it doesn't get put into magnetizableBlocks.

Will submit a pull request shortly probably. Should be an easy fix? just add all of the blocks from the whitelist to the hashset directly. Or implement it with a tag, which is probably the "correct" solution.

Here's logs just in case: https://mclo.gs/FFTl3Rv

@quat1024
Copy link
Collaborator

I believe the recipe crawl system was used over a tag because there's a lot of mods adding recipes using iron and we don't want to worry about adding compat for all of them.

The allowlist/denylist config options definitely should be interpreted as block IDs, not as item IDs, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants