-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add ReentrancyGuard
#192
Comments
ReentrancyGuard
ReentrancyGuard
I'd actually encourage devs to DIY their own reentrancy guard (packed with other variables), so that they save on a cold SLOAD. Hmm... |
I agree with that statement, much like you did with ERC721A. However not all devs will do it and this would be a option for them to use in case they need it. |
I think we might reopen this just to entertain the doubts of contract developers, particularly if an upgrade path (so v0 might have ReentrancyGuard, while v1 bakes). Whether we like it or not, RG is sticky af and often just tells external parties what cannot happen even if wasteful. |
This is a long shot but i think it may be worth a try.
So the idea here is to have solady with all the "standard" contracts much like oz and solmate have.
This way when working with solady as your library of choice you can have all the tools at your disposal instead of having to import from different libraries (unless its very specific). This would make the project have less "bloat" and be cleaner overall.
The code bellow passes on all of solmate's tests as well as saving 100 gas on protected calls.
The text was updated successfully, but these errors were encountered: