Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ LibSort #15

Closed
raxhvl opened this issue Feb 5, 2024 · 5 comments
Closed

✨ LibSort #15

raxhvl opened this issue Feb 5, 2024 · 5 comments

Comments

@raxhvl
Copy link
Contributor

raxhvl commented Feb 5, 2024

Port LibSort from solady as part of #7.

@raxhvl raxhvl mentioned this issue Feb 5, 2024
3 tasks
@atarpara
Copy link
Collaborator

atarpara commented Feb 5, 2024

@raxhvl, could you please explain which parts of LibSort benefit from the new opcodes (such as mcopy, tstore, tload, push0, etc.)? We're trying to avoid moving all files from solady because it's a hassle to upstream new commits from solady to soledge.

@Vectorized
Copy link
Owner

Vectorized commented Feb 5, 2024

I'm leaving this one on hold first. LibSort only has a single copy function.

I think DynamicBufferLib will benefit most from mcopy, as it is literally copying.

@Vectorized
Copy link
Owner

Actually, I'd prefer if there is a library called MemCopyLib instead of LibSort.

It will have functions for copying memory arrays and bytes.

@raxhvl
Copy link
Contributor Author

raxhvl commented Feb 6, 2024

could you please explain which parts of LibSort

@atarpara was hoping to use mcopy in LibSort.copy() - seemed like a gentle start for me.

because it's a hassle to upstream new commits from solady

I can imagine the pain. On a separate note, how are you folks planning to tackle that?

I'm leaving this one on hold first. LibSort only has a single copy function.

Should I close (PR + Issue) for now?

I think DynamicBufferLib will benefit most from mcopy, as it is literally copying.

I will start with this.

It will have functions for copying memory arrays and bytes.

And then this.

@atarpara
Copy link
Collaborator

atarpara commented Feb 6, 2024

Should I close (PR + Issue) for now?

Yes you can close both.

@raxhvl raxhvl closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants