Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] New screenshare UI changes #731

Open
3 tasks done
Tiagoquix opened this issue Jul 5, 2024 · 5 comments
Open
3 tasks done

[Feature Request] New screenshare UI changes #731

Tiagoquix opened this issue Jul 5, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Tiagoquix
Copy link
Contributor

Discord Account

No response

Motivation

Since the new update dropped, I am having two "problems" with the new UI.

First: it's too big/large when compared to the old UI. Before, I was able to select every option before streaming, and now I have to scroll to select audio sources. My resolution is 1366x768.

image

Second: when selecting an item in "Audio Sources" and "Exclude Sources", the menu doesn't close automatically, which, in my opinion, is not what the average user would expect. It doesn't close automatically because it's possible to select multiple sources, but there's no indication on the UI that this is possible. Additionally, most users will just choose "Entire System" instead of choosing a specific app if they want to share system audio.

Solution

For the first issue, the solution would be to restore the old UI or make the current more compact, without the need to scroll to select audio.

For the second issue, the solution is to add a tooltip and require a keypress to select multiple sources (such as CTRL). Without a keypress, the menu would close itself automatically.

Alternatives

I don't know any other alternatives at the moment.

Additional context

Me and a friend of mine consider that the menu not closing itself automatically is bad UX.

Request Agreement

  • I have searched the existing issues and found no similar issue
  • This is not a plugin request
  • This is not a Vencord feature request
@Tiagoquix Tiagoquix added the enhancement New feature or request label Jul 5, 2024
@Tiagoquix
Copy link
Contributor Author

CC @Curve

@Curve
Copy link
Member

Curve commented Jul 5, 2024

For the second issue, the solution is to add a tooltip and require a keypress to select multiple sources (such as CTRL). Without a keypress, the menu would close itself automatically.

I'm not sure if this is even possible with the given discord components

@Curve
Copy link
Member

Curve commented Jul 5, 2024

For the first issue, the solution would be to restore the old UI or make the current more compact, without the need to scroll to select audio.

Restoring the old UI is not exactly a good idea as there would be too much empty space.

I'm open to suggestions on how to make the current layout more compact though

@Faupi
Copy link

Faupi commented Oct 30, 2024

Personally I also think at least the audio sources could have some automatic pre-selection logic, maybe even enabled by some setting in Vesktop. I'm not sure if things like the info about the selected window could be fetched through the portal as I don't know much the handling currently, but for the audio, maybe Vesktop could try to match the selected window's title to the source name and use "Entire system" when it's for a whole screen?
Of course, this could be extended to the resolution and frame rate selection too, but in my opinion this would be better just be saved for the user as a preference, since personally I see myself selecting the same 1080p/60fps every time anyway, which is different from the default.

Currently my flow for starting a simple stream is as follows:

  1. Click "Share your screen" in a Discord call
  2. In KDE portal -> Switch to Window tab > Select Window > Confirm the selection
  3. Set resolution to 1080
  4. Set frame rate to 60
  5. Open audio sources
  6. Select whichever source is relevant (usually of the same name as the window) -> sometimes the dropdown needs to be closed with a click outside of it
  7. Click the "Go Live" button

I would say anything to help streamline this more as a whole would be helpful as the amount of steps (especially thanks to the portal) is making a quick screen share still a bit more involved compared to the native handling on Windows.

If need be:
NixOS unstable 16/10/2024, Wayland KDE Plasma 6.2.1 (frameworks 6.7.0)
Discord Canary 339808 (34b9fed), Vesktop V1.5.3

@Curve
Copy link
Member

Curve commented Oct 30, 2024

the selected window's title to the source name

iirc we don't get that sort of information when desktop portals are used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants