Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #110

Open
Ventan00 opened this issue Sep 26, 2021 · 5 comments
Open

Code refactoring #110

Ventan00 opened this issue Sep 26, 2021 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Ventan00
Copy link
Owner

When do you want to discuss

And decide how to divide between us things to do.

@Ventan00 Ventan00 added the documentation Improvements or additions to documentation label Sep 26, 2021
@pnarozniak
Copy link
Collaborator

I', free on wednesday.

@Ventan00
Copy link
Owner Author

18:00 is ok for you?

@Patrykoss
Copy link
Collaborator

Can we meet around 19:00 tomorrow?

@Ventan00
Copy link
Owner Author

  1. Docs should be writen in english. Endpoints, Interface methods, Extension methods, values in config
  2. HttpService should be moved to folder Services
  3. HttpResponseWrapper should me moved to models
  4. Models from shared should be moved to Server
  5. Config variables should be unified to c# standard
  6. Repositories should be merged (interfaces and repositories)
  7. Razor pages always should contain only html. We should separate .cs .css and razor
  8. Create quanda-auth server and separate endpoints from user
  9. Client/Shared - used on multiple pages, others in Components ordered by folders. When Shared component has multiple subcomponents, then create folder in shared/component name and put all files to this folder
  10. Remove "Component" from components.
  11. Predefined nomenclature of function names ( clicks: handleOnUsersClick(), callbacks: on{Event}())
  12. Pages/Auth/Log,reg pages/Auth/Recover/...
  13. DTO in folders with controller names and function names + request/reposne + dto (GetUsersResponseDTO in DTOs/Users). DTOs used in multiple controllers go to /Shared
  14. Enums in DTOs
  15. urls small-case-dash-separated
  16. no async in controllers

Cleanup code

@Ventan00
Copy link
Owner Author

Ventan: Shared
xlegodroid: Client
Patrykoss: Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants