Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skewed graph for Ammo Damage #70

Open
Roudique opened this issue Aug 5, 2020 · 0 comments
Open

Skewed graph for Ammo Damage #70

Roudique opened this issue Aug 5, 2020 · 0 comments

Comments

@Roudique
Copy link

Roudique commented Aug 5, 2020

Since BSG recently added grenade launchers, there's one special 40x46mm cartridge that has weird stats: M576. It's a buckshot shot shell and has damage value of 121 and 15 projectile count, which results in total damage of 1815.

Most of ammo in Tarkov has damage in rage between 30 and 200, and this 1815 value really messes up damage graph:
image

This happens because the percentage to be filled is calculated as following:
Min total damage value among ALL ammo / Max total damage value among ALL ammo
which results in range 35 -> 1815 and weird UI.

I have a draft PR to add couple tweaks to UI and calculations:
image

What is done there:
— To draw graph, we take min-max values only among ammo of the same type, not among all types;
— Min value is 0, not the actual min value of ammo damage. IMO it will look more natural for most of ammo types:
image
damage is used instead of totalDamage;
— For buckshot, damage is shown as damage x projectileCount instead of totalDamage.

Same could be done for armor damage comparison.

Of course there are downsides. Ammo damage comparison will have "special treatment" and code inevitably will become more complicated and error-prone, but I think improvements in UX are worth it.

@VeritasDev thoughts? I could submit a draft PR if this is something that could be of value.
PR would be reaaally raw because I'm not familiar with codebase and not aware of things I could mess up if I change calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant