Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): performance optimizations #318

Merged
merged 5 commits into from
Mar 17, 2022
Merged

feat(test): performance optimizations #318

merged 5 commits into from
Mar 17, 2022

Conversation

felangel
Copy link
Contributor

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Mar 17, 2022
@felangel felangel self-assigned this Mar 17, 2022
@felangel felangel marked this pull request as ready for review March 17, 2022 20:24
erickzanardo
erickzanardo approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but LGTM already

lib/src/commands/test/test.dart
final targetPath = path.normalize(Directory.current.absolute.path);
final pubspec = File(path.join(targetPath, 'pubspec.yaml'));

if (!pubspec.existsSync()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I m curious why moving this up and not using the exception anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to catch this error before running the pre gen hook since it would fail if a pubspec didn't exist.

@felangel felangel merged commit 8decea0 into main Mar 17, 2022
@felangel felangel deleted the feat/performance branch March 17, 2022 20:34
@felangel felangel mentioned this pull request Mar 17, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @erickzanardo