Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: very_good packages get gets stuck when using dependency via git https link but not authenticated #372

Closed
orestesgaolin opened this issue May 4, 2022 · 1 comment · Fixed by #379
Assignees
Labels
bug Something isn't working as expected

Comments

@orestesgaolin
Copy link

Description
When using pubspec.yaml dependency via https git url, but by default ssh authentication is used (so no ability to clone repository via https), the cli hangs. This caused us some problems as the CI was stuck for many hours on the dependency resolving step.

Steps To Reproduce

  1. Use ssh instead of https authentication on GitHub
  2. Add pubspec.yaml dependency using https link to a private GitHub repository e.g.
my_package:
    git:
      url: https://github.com/org/package.git
      ref: 1a61e2a62094aaf7614a4f8a0063863d21cc6e44
  1. Run very_good packages get
  2. See following prompt indefinitely
❯ very_good packages get
⠋ Running "flutter packages get" in⠸ Running "flutter packages get" in /Users/...

Expected Behavior
The action should fail with the clear information

Additional Context

Maybe timeout would be useful?

@orestesgaolin orestesgaolin added the bug Something isn't working as expected label May 4, 2022
@wolfenrain
Copy link
Member

Related: dart-lang/pub#2242

The very_good_cli should detect this and not keep it running indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants