Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make CLI classes support an injectable Process #380

Closed
2 of 3 tasks
felangel opened this issue May 6, 2022 · 0 comments · Fixed by #444
Closed
2 of 3 tasks

refactor: make CLI classes support an injectable Process #380

felangel opened this issue May 6, 2022 · 0 comments · Fixed by #444
Assignees
@felangel
Labels
refactor A code change that neither fixes a bug nor add a feature

Comments

@felangel
Copy link
Contributor

felangel commented May 6, 2022 •
edited by BeatriceMitchell
Loading

As a developer, I want to be able to refactor all CLI classes to support mocking the underlying Process from dart:io so that we can easily mock the Process in unit tests.

  • dart_cli.dart
  • flutter_cli.dart
  • git_cli.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felangel felangel

Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(flutter_cli): stub test runner in unit tests VeryGoodOpenSource/very_good_cli
2 participants
@felangel @BeatriceMitchell