Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support application_id argument #555

Merged
merged 7 commits into from
Nov 17, 2022
Merged

feat(core): support application_id argument #555

merged 7 commits into from
Nov 17, 2022

Conversation

erickzanardo
Copy link
Contributor

Description

Adds support to the application id. Now supported by very good core.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@erickzanardo erickzanardo marked this pull request as draft November 7, 2022 20:35
@erickzanardo erickzanardo marked this pull request as ready for review November 17, 2022 12:01
wolfenrain
wolfenrain previously approved these changes Nov 17, 2022
View reviewed changes
@felangel felangel added the feature A new feature or request label Nov 17, 2022
@felangel felangel linked an issue Nov 17, 2022 that may be closed by this pull request
fix: org name with 2 parts in identifier Ex. com.example #280
Closed
@felangel felangel changed the title feat: adding application id argument feat(core): support application_id argument Nov 17, 2022
@felangel felangel merged commit 2dff7d5 into main Nov 17, 2022
@felangel felangel deleted the feat/application_id branch November 17, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees

@erickzanardo erickzanardo

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: org name with 2 parts in identifier Ex. com.example
3 participants
@erickzanardo @felangel @wolfenrain