Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GridView Support #79

Open
2 tasks
hintbox opened this issue Oct 5, 2024 · 8 comments
Open
2 tasks

feat: Add GridView Support #79

hintbox opened this issue Oct 5, 2024 · 8 comments
Labels
feature A new feature or request p3 Issues that we currently consider unimportant

Comments

@hintbox
Copy link

hintbox commented Oct 5, 2024

Description

Great library, could you support also gridview for infinite listing

Requirements

  • All CI/CD checks are passing.
  • There is no drop in the test coverage percentage.

Additional Context

No response

@tomarra
Copy link
Contributor

tomarra commented Oct 10, 2024

Hi @hintbox 👋 thanks for opening this issue!

As of right now we don't have a use case that would drive this need for us so I'm going to mark this as a P3 issue. That being said if it is something that you feel you can help implement it would be great to start to detail out what the feature would look like both code architecture wise as well as UI implementation. With that documented here you (or anyone else) could then start down the path of opening a PR to get it reviewed and merged in the future.

@tomarra tomarra added the p3 Issues that we currently consider unimportant label Oct 10, 2024
@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Oct 10, 2024
@shivams1110
Copy link

@hintbox I also need Gridview, So I forked this project and added GridView functionality.

Clone this https://github.com/shivams1110/very_good_infinite_list into your local system and use it.

Use this InfiniteGrid widget.

and let me know if it is helpful.

@tomarra
Copy link
Contributor

tomarra commented Oct 17, 2024

@shivams1110 Any interest in opening a PR to contribute that back?

@shivams1110
Copy link

@shivams1110 Any interest in opening a PR to contribute that back?

Yeah, I am interested But for that, I need to write a test case for this implementation, and after that, I will do it.

@keiwanmosaddegh
Copy link

@shivams1110 amazing contribution, I'd love to see this go all the way! 🤩 Let me know if I can help!

@shivams1110
Copy link

@shivams1110 amazing contribution, I'd love to see this go all the way! 🤩 Let me know if I can help!

Sure please check this pr once, if you can help me in this.

@tomarra
Copy link
Contributor

tomarra commented Nov 12, 2024

Want to compare this against a previous POC that was done #51 based on #34

This was originally turned down due to performance issues so don't want to fall into the same trap again.

@hintbox
Copy link
Author

hintbox commented Dec 18, 2024

hi, any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

4 participants