Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found incorrect SVG path groups and definition #31

Open
kohki-shikata opened this issue Apr 3, 2020 · 3 comments
Open

Found incorrect SVG path groups and definition #31

kohki-shikata opened this issue Apr 3, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kohki-shikata
Copy link

Hi.

I found a wrong data on the map of Japan.
SVG path elements are grouped by prefectures, it's nice.
But some paths are incorrectly grouped next to the prefecture.
Specifically, some islands of Kagoshima prefecture belongs to Okinawa prefecture incorrectly.

So, I decided to correct this fault, but I couldn't figured out how I fix it.

  1. Fork this repo, fix svg data and make PR to here.
  2. Tell this situation to MapSVG project --however I couldn't find MapSVG's contact point.

Which one should I do the way?

@VictorCazanave
Copy link
Owner

VictorCazanave commented Apr 4, 2020

Hi @kohki-shikata ,

Thanks for reporting this issue!

The MapSVG contact page provides 2 ways to contact them. It looks like you must register an account to open a support ticket, so sending an email to support@mapsvg.com may be easier. However I don't know how they will handle this request, because I've never contacted them.

If you know how to fix the SVG file, a PR to this project would also be very much appreciated.

@VictorCazanave VictorCazanave added the bug Something isn't working label Apr 4, 2020
@kohki-shikata
Copy link
Author

I had tried to correct SVG data with Adobe Illustrator. But exported data was slightly modified by Illustrator. Path was shifted just a little bit and made some gaps.

スクリーンショット 2020-04-04 21 46 06

Do you know the app appropriate to edit SVG map?

@VictorCazanave
Copy link
Owner

You can try Inkscape but I don't know if it will work better.

I searched for another SVG file:

  1. this one seems to have the same issue
  2. this one may work but need to check if the data (tags) can be modified to fit the needs of the project

@VictorCazanave VictorCazanave added the help wanted Extra attention is needed label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants