Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alertmanager CRD overlaps with the Prometheus Operator one #35

Closed
clmssz opened this issue Jun 15, 2020 · 5 comments
Closed

Alertmanager CRD overlaps with the Prometheus Operator one #35

clmssz opened this issue Jun 15, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@clmssz
Copy link
Contributor

clmssz commented Jun 15, 2020

Hi there,

Not sure if the files in master are the most up to date ones, since you mention an install directory in the docs and it's not there yet, but in the deploy/crds for vmalertmanagers, singular and plural terms mismatch - If the goal is to use the coreos CRD for alertmanager, better remove it from CRDs here as it will conflict with an already deployed prometheus operator

  names:
    kind: Alertmanager
    listKind: AlertmanagerList
    plural: vmalertmanagers
    shortNames:
    - vma
    singular: alertmanager
@f41gh7 f41gh7 added the bug Something isn't working label Jun 15, 2020
@f41gh7 f41gh7 self-assigned this Jun 15, 2020
@f41gh7
Copy link
Collaborator

f41gh7 commented Jun 15, 2020

Hello, thx for report.

Its the bug, at an early version alertmanager was at coreos api, later ive moved it into victoriametrics api.

I think it`s better to rename it to VmAlertmanager and fix the conflict.

@clmssz
Copy link
Contributor Author

clmssz commented Jun 15, 2020

Candid question : Is there a reason not to use the Coreos one ? Like a victoria alertmanager in the making ? Or you want to separate from Coreos APIs ?
Asking because for us, the use of PrometheusRule, ServiceMonitors etc.. as "standard" is really practical, since we will be migrating from prometheus operator deployments.

@f41gh7
Copy link
Collaborator

f41gh7 commented Jun 15, 2020

The main reason is the conflict with existing prometheus-operator setup. If you run both operators at one cluster it would result in race-condition updates for alertmanager (at coreos api) and may lead to unwanted behaviour.
Plus configuration at victoriametrics api for alertmanager is a bit differ - extraEnv,extraArgs,replicaCount.

@clmssz
Copy link
Contributor Author

clmssz commented Jun 16, 2020

Got it

@f41gh7
Copy link
Collaborator

f41gh7 commented Jun 18, 2020

Renamed to VMAlertmanager, now it's :

  group: victoriametrics.com
  names:
    kind: VMAlertmanager
    listKind: VMAlertmanagerList
    plural: vmalertmanagers
    shortNames:
    - vma
    singular: vmalertmanager

@f41gh7 f41gh7 closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants