-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alertmanager CRD overlaps with the Prometheus Operator one #35
Comments
Hello, thx for report. It I think it`s better to rename it to VmAlertmanager and fix the conflict. |
Candid question : Is there a reason not to use the Coreos one ? Like a victoria alertmanager in the making ? Or you want to separate from Coreos APIs ? |
The main reason is the conflict with existing prometheus-operator setup. If you run both operators at one cluster it would result in race-condition updates for alertmanager (at coreos api) and may lead to unwanted behaviour. |
Got it |
Renamed to VMAlertmanager, now it's : group: victoriametrics.com
names:
kind: VMAlertmanager
listKind: VMAlertmanagerList
plural: vmalertmanagers
shortNames:
- vma
singular: vmalertmanager |
Hi there,
Not sure if the files in master are the most up to date ones, since you mention an
install
directory in the docs and it's not there yet, but in thedeploy/crds
for vmalertmanagers, singular and plural terms mismatch - If the goal is to use the coreos CRD for alertmanager, better remove it from CRDs here as it will conflict with an already deployed prometheus operatorThe text was updated successfully, but these errors were encountered: