Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmalert has two default port #658

Closed
yimenghua opened this issue Jun 2, 2023 · 2 comments · Fixed by #659
Closed

vmalert has two default port #658

yimenghua opened this issue Jun 2, 2023 · 2 comments · Fixed by #659
Labels
bug Something isn't working

Comments

@yimenghua
Copy link

internal]/config/config.go
VMAlertDefault.Port : 8080

api/v1beta1/vmalert_types.go

func (cr *VMAlert) AsURL() string {
	port := cr.Spec.Port
	if port == "" {
		port = "8880"
	}
	return fmt.Sprintf("http://%s.%s.svc:%s", cr.PrefixedName(), cr.Namespace, port)
}

8080 or 8880 ?

@f41gh7
Copy link
Collaborator

f41gh7 commented Jun 2, 2023

Hello, it's a bug. Thx for pointing. It affects only service discovery for vmauth.

@f41gh7 f41gh7 added the bug Something isn't working label Jun 2, 2023
@f41gh7 f41gh7 reopened this Jun 10, 2023
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 3, 2023

Fixed at v0.35.0 release

@f41gh7 f41gh7 closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants