Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for DJAS016 (settings) #40

Open
3 tasks
Viicos opened this issue Jan 23, 2024 · 0 comments
Open
3 tasks

Improvements for DJAS016 (settings) #40

Viicos opened this issue Jan 23, 2024 · 0 comments

Comments

@Viicos
Copy link
Owner

Viicos commented Jan 23, 2024

Following #37:

  • What to do if the project settings sets a different type from the global one? e.g. a global type is defined as str | None (default is None), but the project sets a string. Should we use the project type? Should the behavior be configurable? This also does not apply to all cases, e.g. booleans: probably doesn't make sense to set it as Literal[True/False]?
  • Figure out what types can be used for PathLikes: check source code and stubs, push fixes in stubs if necessary. (This is related to the previous point).
  • What about custom settings: works fine with primitives, what if lists/dicts are being used? Would be nice to parse the AST of the module where it is defined, so that docstrings can also be pulled out.

Wrong types:

  • LANGUAGE_COOKIE_AGE/SESSION_COOKIE_AGE: int or timedelta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant