Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing ReverseOverloadCodemod (DJAS015) #70

Open
Viicos opened this issue Jul 11, 2024 · 0 comments
Open

Consider removing ReverseOverloadCodemod (DJAS015) #70

Viicos opened this issue Jul 11, 2024 · 0 comments

Comments

@Viicos
Copy link
Owner

Viicos commented Jul 11, 2024

It currently crashes on some projects, is missing some viewnames, is relatively slow on some big projects (even when disabling args typechecking), and some long view names aren't fully auto-completed in pyright as it has a hardcoded limit of 50 characters. Ideally the rule should either be:

  • removed.
  • changed to only have a single definition, with all the viewnames in one Literal. We drop support for typechecking args/kwargs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant