Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Trigger action for giving credits to a house #158

Open
Rampastring opened this issue May 12, 2021 · 2 comments · May be fixed by #1122
Open

[New Feature] Trigger action for giving credits to a house #158

Rampastring opened this issue May 12, 2021 · 2 comments · May be fixed by #1122
Labels
new-feature New feature or request.
Milestone

Comments

@Rampastring
Copy link
Member

Description:

Tiberian Sun doesn't have a trigger action for giving credits (money) to a house. CnCNet ts-patches adds one.

Additional Files:

CnCNet ts-patches implementation: https://github.com/CnCNet/ts-patches/blob/master/src/trigger_actions_extended.asm#L94

The ts-patches implementation has a bug that, while the trigger action works for multiplayer houses (that normally cannot be used in any triggers in vanilla TS), it doesn't work for singleplayer houses.

@Rampastring Rampastring added the new-feature New feature or request. label May 12, 2021
@Rampastring Rampastring added this to the TS-Patches milestone May 12, 2021
@CCHyper
Copy link
Contributor

CCHyper commented May 12, 2021

Has research been done as to why this does not work for single-player houses? Could this be a side-effect of the current ts-patches "spawner" system?

@Rampastring
Copy link
Member Author

Research hasn't been done on it. I can't remember any issues with other trigger actions for single-player houses, so I'd guess it's a bug in the implementation of the specific action instead. But I'm not entirely certain.

@CCHyper CCHyper self-assigned this Jun 11, 2021
@CCHyper CCHyper moved this to In Progress in Vinifera - Initial Release Apr 8, 2022
@CCHyper CCHyper removed their assignment Oct 7, 2024
@ZivDero ZivDero linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request.
Projects
Status: In Progress
2 participants